- marked as minor
Eigen all the way?
Issue #12
new
How about we completely abandon Vector.h and Matrix.h for version 3.0?
Comments (9)
-
reporter
-
Yes, @fdellaert, I'm in favor of this. Should I do it, or somebody else?
-
reporter
You could work with @jdong37 ?
-
Will this cause compatibility issue of old code since we remove all our previous definition? I think one possible solution that we remain Vector.h and Matrix.h, but not use ourselves implementation, use Macros to redirect our declaration to Eigen's implementation. This won't lower runtime performance and has better compatibility than just remove them.
-
There are a few useful things which might be worth keeping: stream operator, DLT, print, etc. Actually, in cleaning up my own code I noticed Eigen has this for printing: http://eigen.tuxfamily.org/dox/structEigen_1_1IOFormat.html
-
reporter
Yeah, Eigen has nice streaming operators. I agree, @cbeall3, we should probably try to do this and then see what does not have an Eigen equivalent, i.e., what's left. Then decide what to do with this. It'll all be in a branch, of course.
-
-
assigned issue to
Alex Hagiopol
@alexhagiopol were you not going to deprecate some methods that are pure pass-throughs in Vector.h and Matrix.h ? If you restrict yourself to that simple task (and don't bite off more) this should be relatively straightforward.
-
assigned issue to
-
Will do.
-
How about a Matrix.h push ? :-)
- Log in to comment
