Last develop merge has link errors!!!

[Frank Dellaert]

I will try to fix ASAP but @cbeall3 if you can see what's wrong please help.

Here is a sample:

Undefined symbols for architecture x86_64:
  "gtsam::PinholeBase::project_to_camera(gtsam::Point3 const&, gtsam::OptionalJacobian<2, 3>)", referenced from:
      gtsam::PinholeCamera<gtsam::Cal3Bundler>::projectPointAtInfinity(gtsam::Point3 const&, gtsam::OptionalJacobian<2, 6>, gtsam::OptionalJacobian<2, 2>, gtsam::OptionalJacobian<2, 3>) const in testCERESQRSolver.cpp.o
      gtsam::PinholeCamera<gtsam::Cal3_S2>::projectPointAtInfinity(gtsam::Point3 const&, gtsam::OptionalJacobian<2, 6>, gtsam::OptionalJacobian<2, 2>, gtsam::OptionalJacobian<2, 5>) const in testCERESQRSolver.cpp.o
  "gtsam::PinholeBase::print(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) const", referenced from:
      gtsam::TriangulationFactor<gtsam::Cal3Bundler>::print(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, boost::function<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > (unsigned long)> const&) const in testCERESQRSolver.cpp.o
      gtsam::GenericValue<gtsam::PinholeCamera<gtsam::Cal3Bundler> >::print(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) const in testCERESQRSolver.cpp.o
      gtsam::PriorFactor<gtsam::PinholeCamera<gtsam::Cal3Bundler> >::print(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, boost::function<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > (unsigned long)> const&) const in testCERESQRSolver.cpp.o
      gtsam::TriangulationFactor<gtsam::Cal3_S2>::print(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, boost::function<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > (unsigned long)> const&) const in testCERESQRSolver.cpp.o
  "gtsam::PinholeBase::equals(gtsam::PinholeBase const&, double) const", referenced from:
      gtsam::TriangulationFactor<gtsam::Cal3Bundler>::equals(gtsam::NonlinearFactor const&, double) const in testCERESQRSolver.cpp.o
      gtsam::GenericValue<gtsam::PinholeCamera<gtsam::Cal3Bundler> >::equals_(gtsam::Value const&, double) const in testCERESQRSolver.cpp.o
      gtsam::PriorFactor<gtsam::PinholeCamera<gtsam::Cal3Bundler> >::equals(gtsam::NonlinearFactor const&, double) const in testCERESQRSolver.cpp.o
      gtsam::TriangulationFactor<gtsam::Cal3_S2>::equals(gtsam::NonlinearFactor const&, double) const in testCERESQRSolver.cpp.o
  "gtsam::PinholeBase::project2(gtsam::Point3 const&, gtsam::OptionalJacobian<2, 6>, gtsam::OptionalJacobian<2, 3>) const", referenced from:
      gtsam::PinholeCamera<gtsam::Cal3_S2>::project(gtsam::Point3 const&, gtsam::OptionalJacobian<2, 6>, gtsam::OptionalJacobian<2, 3>, gtsam::OptionalJacobian<2, 5>) const in testCERESQRSolver.cpp.o
      gtsam::PinholeCamera<gtsam::Cal3Bundler>::project(gtsam::Point3 const&, gtsam::OptionalJacobian<2, 6>, gtsam::OptionalJacobian<2, 3>, gtsam::OptionalJacobian<2, 3>) const in testCERESQRSolver.cpp.o
      gtsam::PinholeCamera<gtsam::Cal3Bundler>::project2(gtsam::Point3 const&, gtsam::OptionalJacobian<2, 9>, gtsam::OptionalJacobian<2, 3>) const in testCERESQRSolver.cpp.o
ld: symbol(s) not found for architecture x86_64

[Frank Dellaert]

Note the above is smartfactors_ceres. Links before my PinholeCamera overhaul, now no longer. Hence, is independent of SmartFactors2 branches.

[Frank Dellaert]

Changed to Critical as I checked in a fix that at least allows linking.

[Frank Dellaert]

Seems it might have been a local minimum on my mac. @cbeall3 undid fix in pull request #140