Remove dangerous Vector_(3,...) style constructors

Issue #30 resolved

Frank Dellaert created an issue 2014-01-23

I ran into another frustrating bug because of this. I propose we remove them before releasing 3.0. @richardroberts, agree? Jing, can you remove them?

Search for the variable argument C code... I know at least 3 locations (Vector,Matrix,LieVector).

Comments (8)

Frank Dellaert reporter
- edited description
- 2014-01-23T03:36:14+00:00
Jing Dong
I think I may miss some of them previously... anyway, I will fix them now. @richardroberts should I fork a new branch or directly fix them in develop branch?
- 2014-01-23T04:08:42+00:00
Frank Dellaert reporter
No, I mean, remove the functions now. If you missed any, they will no longer compile...
- 2014-01-23T04:18:05+00:00
Frank Dellaert reporter
Always branch from now on, e.g. support/noMoreVector_
- 2014-01-23T04:19:07+00:00
Richard Roberts
yes, I agree we should remove them. I think another good thing if we have time is to make all functions in matrix and vector .h, .cpp, implemented as inline functions that just call the proper Eigen call and return the proper expression type. Instead of the slow implementations we currently have.

Do you think this is worth investing the time in for 3.0?
- 2014-01-23T07:38:07+00:00
Frank Dellaert reporter
Please see issue #12 and tell me what you think
- 2014-01-23T15:53:55+00:00
Frank Dellaert reporter
@jdong37 please close this issue if it's done. And thanks !!!!
- 2014-01-28T05:31:58+00:00
Jing Dong
- changed status to resolved
- 2014-01-28T20:36:46+00:00
Log in to comment