Milestone 8.0.1
- Achieve feature parity with svn repo
- Automatic testing (master only)
Official response
Comments (13)
-
-
reporter It might be worth referring to the relevant issue numbers as well.
-
-
Here's the list of PRs I think are being considered for 8.0.1:
PR #3 Use le_layout for collisions by default [Delayed, waiting for tests]
PR #10 adding redistribution benchmarks (requires utils PR #3)
PR #11 auto-checkout of submodules
PR #17 tidying up makefiles
PR #19 contributing docs
PR #20 code coverage with gcov
PR #23 fix variable assignment problem in Makefile
PR #24 Fixed a bug where negrid was not set in calculate_f0_arrays_tabulated.
PR #25 Delete collisions tests, which are a repeat of le_grids tests
PR #31 Test coverage tracking with Codecov
PR #32 Skip gf test when appropriate
PR #33 Fix lowflow routines
PR #35 improve test messages
utils
makefiles
-
Presumably all PRs already merged into next will also be included, right?
-
Yes, that's right. These will go to
next
, thennext
gets merged tomaster
. -
OK, and all other open PRs will get held back until after that merge of next into master, then they can go into next which then represents 8.1.0?
-
Yep. Though the above list isn't definitive - if I'm missed anything, or included something dumb, please shout!
-
OK, cool. The list above looks good to me - includes sensible stuff and excludes PRs that should be held back. One addition though - I have noticed that some of the updates to the makefiles and utils submodules have not been included in the gs2 repo yet - we need a commit to the gs2 repo that updates which commit from the submodules should be used.
-
reporter Yes agree we should make sure
master
@v8.0.1 is updated to point to the correct version of the sub-modules.On a related note we'll probably want to port some of these fixes/changes to the other codes in the gyrokinetics team such that their masters will build.
-
Good point about other codes. On my machine, AGK master builds with both utils master and utils next. There's no test suite though...
-
reporter If there are no tests then I think the best we can do is check they compile
-
- changed status to resolved
- Log in to comment
Here's the list of PRs I think are being considered for 8.0.1:
utils
makefiles
next -> master