OpenXML: Document becomes corrupt during merge

[Chase Tingley]

When the attached document is round-tripped, it produces a target file that is corrupt and fails to open in Word.

Reproducible in tikal on M30 dev:

/Applications/okapi-apps_cocoa-macosx-x86_64_0.30-SNAPSHOT/tikal.sh -fc okf_openxml -x Marketing.docx
/Applications/okapi-apps_cocoa-macosx-x86_64_0.30-SNAPSHOT/tikal.sh -fc okf_openxml -m Marketing.docx.xlf

[Chase Tingley]

This is entity corruption in the docProps/core.xml part:

<cp:lastModifiedBy>Patrick & Rebecca</cp:lastModifiedBy>

[Chase Tingley]

I'm just making a note here that I bet the code in issue #532 will similarly break if an & is used in a sheet name. The old OpenXMLContentFilter (which is not used for much any more) is very vulnerable to this.

[Chase Tingley]

My fear about the Excel sheet name case was unfounded, that works fine. I have a fix for this.

[Chase Tingley]

Fix issue #536 and remove some dead code

→ <<cset 78ed4acb16be>>