- changed title to Property.NOTE marked as deprecated but annotations not implemented in XLIFFWriter?
- edited description
Property.NOTE marked as deprecated but annotations not implemented in XLIFFWriter?
Issue #595
resolved
I don't think Property.NOTE should be marked as deprecated until XLIFFWriter uses the proposed replacement, XLIFFNoteAnnotation. In a custom filter I replaced:
tu.setProperty(new Property(Property.NOTE, note.toString(), true));
with:
XLIFFNoteAnnotation annotation = new XLIFFNoteAnnotation();
annotation.add(new XLIFFNote(note.toString()));
tu.setAnnotation(annotation);
Only to find out it really isn't supported.
Comments (5)
-
reporter -
I can look at this - we must have missed updating code that deals with the previous PROPERTY.
-
-
assigned issue to
-
assigned issue to
-
- changed status to resolved
Jim, if you put "Fix issue
#595" in your commit message, this will resolve automatically when you merge! -
I had to merge this one manually because of a strange conflict. Must be why the ticket didn't close automatically - though I saw it had been merged.
Jim
- Log in to comment