XLIFF Filter does not update state attribute

[YvesS]

The XLIFF Filter reads the target state attribute in the property Property.STATE, but it is read-only and cannot be updated.

We need to implement read-write support for several reasons:

• The SDLXLIFF writer does update SDL-specific attributes related to state, but does not update state properly.
• the OmegaT Filters plugin is waiting for read-write support to allow the state to be updated when working from OmegaT.
• The state attribute is used more and more in processes, we simply need to be able to update it.

[Chase Tingley]

I tagged commit 8e61c3c299d8 against this bug, but it's a mistake -- that commit is for issue #662.

[Kuro Kurosaka (BH Lab)]

@YvesS , could you tell me what you mean by “property Property.STATE” … “is read-only”?

In the unit test case XLIFFFilterTest#testUseTranslationTargetState(), a new value is assigned to the “state” property of a target element, and the test is passing. So I’m puzzled.

‌

[jhargrave-straker]

@YvesS I don’t see any place in the skeleton writers where Property.isReadOnly() is even used. But I did confirm that STATE is being updated and modified the STATE UNIT TEST to check for this.

‌