Refactor profiles in pom.xml(s) the be consistent across projects

[Denis Konovalyenko]

This is the original comment from Mihai.

The idea with disabling some plugins by default is that they don’t slow down people building on their own machines.

We don’t want someone to build and waste time generating javadoc, sources, digitally sign (will probably not even have the pgp keys) or deploy.

I was thinking about refactoring the profiles anyway. There are (unnecessary) differences between Okapi and XLIFF-Toolkit.

And they feel kind of “improvised” (probably because “history”).

I was thinking either more “compact” (e developer profile and a CI/CD profile), or (the opposite) more modular: javadoc, sources, sign, deploy That way one can generate javadoc and sources without deploying. I have found that handy at times.

[Denis Konovalyenko]

I would personally go with the "more modular" approach.

[Mihai Nita]

Current profiles and what they do:

Okapi, superpom\pom.xml

• sign_and_deploy
  • maven-gpg-plugin
  • nexus-staging-maven-plugin
• with_sources
  • maven-source-plugin
  • maven-javadoc-plugin
• release_or_snapshot
  • properties-maven-plugin // defines jna.nosys=true
• reports
  • maven-project-info-reports-plugin
  • clirr-maven-plugin
  • findbugs-maven-plugin
  • jdepend-maven-plugin
  • dependency-updates-report
  • plugin-updates-report
  • property-updates-report
• errorprone
  • maven-compiler-plugin
  • plexus-compiler-javac-errorprone
  • error_prone_core

Xliff-Toolkit, okapi\pom.xml

• sign_and_deploy
  • maven-gpg-plugin
  • maven-deploy-plugin
  • nexus-staging-maven-plugin
• release
  • attach-sources
  • attach-javadocs

Okapi Integration Tests

No profiles.

To be expected. There is nothing fancy here: no signing, maven central, generating javadoc, package source, reports, etc.

[Mihai Nita]

We should do this after Jenkins shutdown. Otherwise the Jenkins builds will fail, or we will need to change the Jenkins settings too, for a few days only.