New duplicates code refs #610, update QR docs refs #506

Merged
#176 · Created  · Last updated

Merged pull request

Merged in issue506documentQR (pull request #176)

435a931·Author: ·Closed by: ·2018-04-15

Description

Hi @dplatten, @tcdewit, @LuukO, anyone else who is watching! Would appreciate any testing anyone can do using this QR code; also please look through the docs at http://docs.openrem.org/en/issue506documentqr/netdicom-qr.html and comment :-)

  • Altering the text and order of the -sr option in web interface. Refs #607, #475

  • Altering the text of command line args to match -sr option in web interface. Refs #607, #475

  • Small tweaks to qr docs refs #506

  • Added SeriesInstanceUID to GeneralStudyModuleAttr model. Added SeriesTime to DicomQRRspSeries model. Added SeriesInstanceUID to rdsr extractor. Moved remove_duplicates to much later in process to ensure series level data is available. Started to implement ref #610

  • Added asking for series time in C-find, added MG/DX logic. Should work now, need to add tests. ref #610

  • Factored remove duplicates code into separate function to make it testable. Refs #610

  • Added tests for RDSR in remove duplicates. Refs #610

  • Added tests for DX in remove duplicates. Refs #610

  • Updated 'advanced' documents for QR. Need to add links and add logic section. Refs #506

  • Starting query filtering logic documentation. Refs #506

  • Correcting indentation. Hopefully. Refs #506

  • Another attempt. Refs #506

  • Correcting to double back ticks Refs #506

  • Continuing with logic for QR. Refs #506

  • Trying specified letters for sublist. Refs #506

  • Reorganising the list to see if it is easier to read. Refs #506

  • Headings didn't work. Trying bold. Refs #506

  • Changed the style again, added fluoro, confused as to logic... Refs #506

  • Updated code doc string for _check_sr_type_in_study to reflect actual behaviour. Refs #506

  • Added explanatory comment to MG, DX and FL series pruning. Removed code to delete 'other' SR types as this will have already been done. FL retains ESR even though we can't currently process them as we will need this for Siemens Arcardis when ref #433 is dealt with. Will help make ref #506 easier to write! Refs #472.

  • Added explanation for CT, PEP8 corrected variable name to lowercase. Refs #506

  • If no RDSR/ESR and series descriptions aren't returned, Toshiba image retrieval will now still work. Refs #546, #472.

  • Completed logic description for series pruning. Refs #506

0 attachments

0 comments

Loading commits...