School fields requiring validation

Brian Lewis repo owner

this may end up forcing a bit of refactoring in EditController.ts I think, because save() doesn't actually go via modelForm.submit ....

2016-05-23T05:03:22+00:00

Brian Lewis repo owner

skip that... on closer inspection, shouldn't matter

2016-05-23T05:14:04+00:00

Ghislain Hachey reporter

Do you have any objection while I am at it to add some basic validation stuff in there? This project seems pretty good at first glance

2016-05-23T21:11:18+00:00

Ghislain Hachey reporter

On second look angular-validate only offer URL and email as out-of-the-box extra over angular built-in. It was looking for the easiest quickest way to put some basic validation stuff in there.

2016-05-23T21:16:09+00:00

Brian Lewis repo owner

I have looked at angular-validate and thought it would be good to include at some point. I like the schema extension too - Conceptually I've always thought there's a bit of conflict in having validations built into the view, when these are really "business rules" that ought to be defined in the "model". The schema approach offers a way that the "model" can own the business rules, and communicate them to any view as required.

ng-messages is another piece of the validation eco-system well worth considering.

Maybe we do this in Honiara? ( start making a list!)

2016-05-23T22:13:21+00:00

Ghislain Hachey reporter

Yeah. For now I got it working nicely. I'll be submit PR soon. Just basic for now. We can improve but other priorities. And yes, what you say makes sense. So maybe we create another issue for this and may get to it while in Honiara or soon afterwards.