Port plottable pie and horizontal bar charts

Issue #840 resolved
Ghislain Hachey created an issue

No description provided.

Comments (2)

  1. Brian Lewis repo owner

    @Ghislain Hachey I have resolved the exam dashboard issue and updated branch issue840, including bringing that up to date with develop.

    In the end, the fix is in #851 : in particular line 309 ff 😀 in createChart, steps were omitted from the option setup if option.series.length == 0 (see  <<cset e4b6ad5a24cf>>)

    So - because of timing issues, the chart got created with no data, out of the $postLink hook.

    • then the option got created, without axes amongst other things.
    • onChartRender then errored because option.xAxis was undefined
    • this error aborted the $postLink sequence
    • because $postLink stopped, the final configuration of the angularjs material directives didn't happen
    • For that reason, the classes layout-column, layout-fill, flex did not get applied where they needed to be
    • This meant that the chart height was never properly propagated down from the dashboard-child to the echart
    • So even if the chart subsequently got some data and got correctly redrawn, it didn't have any screen space to draw into - just default 100 px

    So there are some changes in RowColChart (see #851 which also fix another error I had observed #852 )

    This is the fix, but other changes are:

    • in the SchoolExamBenchmark class, moved to a more reliable and easier to read way of handling onChartRender, by merging into option
    • fixed up the tooltipper in that class, which was an old function aimed at plottable.
    • some minor tweaks due to changes in palette management that have come in from develop

  2. Log in to comment