[TIME-12] Upgrade plugin to work with JIRA 3.7

[Andriy Zhdanov]

Hi,

It seems to me that the plugin does not work with newest JIRA 3.7.
See log below:

SEVERE: Could not execute action
java.lang.NoClassDefFoundError: com/atlassian/jira/issue/action/Worklog
at com.fdu.jira.plugin.report.timesheet.TimeSheet.getTimeSpents(TimeSheet.java:111)
at com.fdu.jira.plugin.report.timesheet.TimeSheet.generateReport(TimeSheet.java:214)
at com.fdu.jira.plugin.report.timesheet.TimeSheet.generateReportHtml(TimeSheet.java:266)
at com.atlassian.jira.web.action.browser.ConfigureReport.doExecute(ConfigureReport.java:96)
at webwork.action.ActionSupport.execute(ActionSupport.java:153)
at com.atlassian.jira.action.JiraActionSupport.execute(JiraActionSupport.java:54)
at webwork.dispatcher.GenericDispatcher.executeAction(GenericDispatcher.java:132)
at com.atlassian.jira.web.dispatcher.JiraServletDispatcher.service(JiraServletDispatcher.java:209)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:856)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:284)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:204)
at com.atlassian.jira.web.filters.AccessLogFilter.doFilter(AccessLogFilter.java:51)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:233)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:204)
at com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilter.java:119)
at com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:55)
at com.atlassian.jira.web.filters.SitemeshExcludePathFilter.doFilter(SitemeshExcludePathFilter.java:38)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:233)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:204)
at com.atlassian.seraph.filter.SecurityFilter.doFilter(SecurityFilter.java:182)

It would be great if you could upgrade it so that it works with 3.7 asap.
Currently it's a showstopper for my team (makes cutover to 3.7 unacceptable), as we strongly depend on such functionality.

By elmadir/Wojciech Seliga on Tue, 2 Jan 2007 09:58:46 -0800

[Andriy Zhdanov]

Could you at least provide rough timeframe when one can expect this upgrade?

By elmadir on Tue, 2 Jan 2007 09:59:51 -0800

[Andriy Zhdanov]

+1 from us too.

Thanks in advance!

By leaskc on Fri, 5 Jan 2007 12:30:43 -0800

[Andriy Zhdanov]

The following thread may be of some help with updating to 3.7.

http://forums.atlassian.com/thread.jspa?messageID=257239154

It seems that the com.atlassian.jira.issue.action.Worklog class has been replaced with the com.atlassian.jira.issue.worklog.Worklog class.

By johneric on Mon, 8 Jan 2007 16:15:56 -0800

[Andriy Zhdanov]

I've realized the problem (thanks for commenting), but plugin needs significant rework because of this change. I'll try to work on it on Saturday.

By azhdanov on Thu, 11 Jan 2007 13:53:29 -0800

[Andriy Zhdanov]

That would be great. Thanks in advance.

By elmadir on Fri, 12 Jan 2007 03:40:35 -0800

[Andriy Zhdanov]

Upgraded to Jira 3.1.7 - reworked usages of Worklog

By azhdanov on Fri, 12 Jan 2007 13:39:15 -0800

[Andriy Zhdanov]

Andres, thanks a lot for the fix. Now plugin works with JIRA 3.7.1, but I found some display related problem (maybe the same what is mentioned in issue #13 "[TIME-13] Incorrect display in portlet.").
In portlet everything seems to be OK, but on report I often (depends on time period I am generating report for) I got totally disordered table.
Take a look at attachment.

By elmadir on Tue, 16 Jan 2007 07:35:38 -0800

[Andriy Zhdanov]

Let me reopen this issue until you clarify why this layout problem I've just mentioned are happening. Maybe it should be a separate issue then.

Thanks in advance.

By elmadir on Tue, 16 Jan 2007 07:37:19 -0800

[Andriy Zhdanov]

Found one more strange thing (maybe some kind of bad interaction betwen Timesheet plugin). The sum calculated is bad...

By elmadir on Tue, 16 Jan 2007 08:00:20 -0800

[Andriy Zhdanov]

Whoops, I've literally just created this issue as issue #15 "[TIME-15] Previous day's hours incorrectly shown in today's column"

By leaskc on Tue, 16 Jan 2007 08:13:35 -0800

[Andriy Zhdanov]

i just created issue #17 "[TIME-17] Wrong displaying of time in TimeSheet portlet" and John Enters add a comment in it telling that is a duplicate of issue #13 "[TIME-13] Incorrect display in portlet.".

I don't care what's duplicate or not here.. i just want the $textUtil.getPrettyHours($timeSpent) bug to be fixed. I don't know on what issue to report it. it seems that everyting is a duplicate from this one..

But i know one thing, Im evaluating Jira and i just download the 3.7.1 version with the last version of the plugin. which is from yesterday because the bug that ive report yesterday morning ( issue #16 "[TIME-16] Hours are not displayed correctly in Time Sheet Report for worklogs of the same day") is fixed in my version... but i still need to have the $textUtil.getPrettyHours($timeSpent) fixed to begin using this plugin.

Im sure not the only one out there still having this problem

Thanks

By smathieu on Wed, 17 Jan 2007 08:34:07 -0800

[Andriy Zhdanov]

ok, forgot my last comment, everything seems to have been fixed yesterday bewteen 2 downloads of the last jar file, a juste re-download it and it worked fine

By smathieu on Wed, 17 Jan 2007 08:44:16 -0800

[Andriy Zhdanov]

Hi Andrew,

Concerning the mis-display discribed by screenshot 2, it is due to my contribution.
You will have to replace in timesheet-entry.vm from Line 26, the following block
#if ($timespents)
#if ($timespents.get($dayOfMonth))
#set ($timeSpent = $timespents.get($dayOfMonth))
#set ($cellCSS = "$weekDay.weekDayCSS workedDay")
#else
#set ($timeSpent = 0)
#set ($cellCSS = "$weekDay.weekDayCSS nonWorkedDay")
#end
#else
#set ($timeSpent = 0)
#end

by

#if ($timespents)
#if ($weekTotalTimeSpents.get($dayOfMonth))
#if ($timespents.get($dayOfMonth))
#set ($timeSpent = $timespents.get($dayOfMonth))
#set ($cellCSS = "$weekDay.weekDayCSS workedDay")
#else
#set ($timeSpent = 0)
#set ($cellCSS = "$weekDay.weekDayCSS nonWorkedDay")
#end
#else
#set ($timeSpent = 0)
#set ($cellCSS = "$weekDay.weekDayCSS nonWorkedDay")
#end
#else
#set ($timeSpent = 0)
#end

Sorry for that again.
Vincent

By kaamelot on Wed, 17 Jan 2007 10:00:24 -0800

[Andriy Zhdanov]

Great!

By azhdanov on Wed, 17 Jan 2007 13:52:21 -0800

[Andriy Zhdanov]

Hi Vincent, thank you, I've fixed it (available in v. 1.5 and 1.6)

By azhdanov on Thu, 18 Jan 2007 03:30:15 -0800