Eigen variant still needed?
Issue #262
on hold
In Matrix.cpp it says:
#ifdef GTSAM_USE_SYSTEM_EIGEN
// System-Eigen is used, and MKL is off
Eigen::internal::householder_qr_inplace_blocked<Matrix, HCoeffsType>(A, hCoeffs, 48, temp.data());
#else
// Patched Eigen is used, and MKL is either on or off
Eigen::internal::householder_qr_inplace_blocked<Matrix, HCoeffsType>::run(A, hCoeffs, 48, temp.data());
#endif
Is this still needed with the new Eigen?
Comments (2)
-
-
reporter
- changed status to on hold
Not ready yet to drop support for Eigen 3.1
- Log in to comment
This is here for backwards compatibility with older versions (3.1 and prior) of system-installed Eigen. The "run" method first appeared in Eigen 3.2.
Eigen 3.1 was released in June 2012, so I'm not sure we already want to drop support for that.