python VisualISAM2Example.py incorrectly sets relinearization threshold

Issue #365 resolved
Alexander Spitzer created an issue

The python ISAM2 example sets "relinearize_threshold", which is not connected to the exported property "relinearization_threshold". This can lead to some confusion.

What is GTSAM's future plan for the Python wrapper? I've added more Python exports in this fork: https://bitbucket.org/pumaking/gtsam/branch/feature/more_python

Should I submit a pull request or is this version of the Python wrapper deprecated?

Comments (4)

  1. Frank Dellaert

    Alexander, sorry about delay: I came back from an extended leave and just going through issues. please take a look at PR #323, which has a new ISAM example. The new cython-based wrapper automatically wraps everything in gtsam.h, so we are going to go that way, and remove the handwritten wrapper. It would be nice to have a repo with the old wrapper that can build against an existing gtsam install, if you're interested in taking that on.

    Let me know if the new example still has this issue (I think not) and we will close this issue.

  2. Log in to comment