incorrect cython for NonLinearOptimizer::iterate

Issue #416 closed
matthew.broadway created an issue

the method NonLinearOptimizer::iterate() has the signature:

virtual GaussianFactorGraph::shared_ptr iterate() = 0;

but the generated cython does not return the result (from gtsam.pyx):

    def iterate(self):
        self.CNonlinearOptimizer_.get().iterate()

I think the correct output should be

    def iterate(self):
        cdef shared_ptr[CGaussianFactorGraph] ret = self.CNonlinearOptimizer_.get().iterate()
        return GaussianFactorGraph.cyCreateFromShared(ret)

but I'm not sure exactly where the problem is within wrap's source code. I will attempt to fix this but I may not have time.

Comments (2)

  1. Log in to comment