PPTx bold not detected & master slide generate extra tags

[Philippe Henri]

Hello,

Please find attached an example where bold is not detected, and this corrupts the formatting when restoring the original file (all text becomes bold): see file withoutmasterslide.pptx

I note also that when the same file has a master slide, some extra surrounding tags are generated instead of surrounding only the formatted words ? see withmasterslide.pptx

I include both files the xlf and the result restored (…out.pptx)

ps: using PowerPoint for Mac v16

thanks

philippe

‌

[jhargrave-straker]

I've added this file to our integration tests and under the current dev code passes. There's a good chance this has been fixed.

[Philippe Henri]

thanks Jim - but can you include also withoutmasterslide.pptx to your tests because as I said there are two problems. look the withmasterslide.out.ppts (generated by tikal.sh), show all formatting corrupted → all text is bold !! see attached screen cap. thanks.

‌

[jhargrave-straker]

Any logged warnings from tikal? I I think the tkitMerged file is the same as your out file (merged result?). But I will add it in any case/

[Philippe Henri]

And to be complete, here is a screen cap of the first problem, instead of surrounding the word “bold” which is in bold, it surrounds the text before and the text after with tags (instead of doing only …<g>bold</g>…), or does nothing in the second pptx….

‌

[Philippe Henri]

nope, no message from tikal

[jhargrave-straker]

The out file also passes. Can you try with the latest snapshot okapi 1.43.00?

[Philippe Henri]

ok i will try and let you know, thanks.

[Philippe Henri]

I tried, exactly the 2 same problems :(

it may pass the test but the result is corrupted and the tags are in the wrong place as detailled above. ps: i suspect the formatting might come from the slide master layout (otherwise why would okapi add tags at the begining of the segment instead of around the word “bold” only)?

[Denis Konovalyenko]

@Philippe Henri , withmasterslide.pptx document has been successfully round-tripped on the latest dev (1.44-SNAPSHOT).

Original document UI:

‌

Merged document UI:

‌

Do you think you would be able to check the issue against the latest snapshot version?

[Denis Konovalyenko]

@Philippe Henri , please do not bother about the check! There is a confirmation of styles mismatch for withoutmasterslide.pptx document.

Original document UI:

‌

Merged document UI:

‌

[Philippe Henri]

thanks Denis, I will try (sorry for the late answer, i didn't see it !!)

[Philippe Henri]

ah oops, i see the problem is still there?

ps: where can i find the 1.44 snapshot, the lastest snapshot link from main page https://okapiframework.org/ seems broken :https://gitlab.com/okapiframework/okapi/-/jobs/artifacts/dev/browse/deployment/maven/done?job=verification:jdk8

[Denis Konovalyenko]

@Philippe Henri a related pull request #704 was merged. Could you please see if the solution works for you?