1. OpenREM Avatar OpenREM
  2. OpenREM
  3. OpenREM
  4. Issues

Drillup from histogram breaks if more than one chart is displaying a histogram

Issue #226 resolved
David Platten created an issue

This is due to an error in the Highcharts code, which has been fixed.

Comments (17)

  2. David Platten reporter

    Updating Highcharts code has stopped the code that was removing x-axis text decoration JavaScript from working. I've replaced the JavaScript solution with a simple bit of css. All working again now. References issue #226. This has the side-effect of making it possible to drill-down to the histogram data by clicking on the x-axis label as well as the corresponding column.

    → <<cset 897d02d960ca>>

  4. Ed McDonagh

    Hi @dplatten - as and when this is closed, I'll create a beta 4. Do you foresee any further changes that might need to be made before we release?

  5. David Platten reporter

    Hi @edmcdonagh - there is something I need to fix with the combined DLP and CTDI plot. If you click on a column belonging to an acquisition's mean DLP or CTDI you are taken to a histogram of the corresponding data. However, if you click on an x-axis label instead then are taken to a histogram that shows both DLP and CTDI histograms, but with only the CTDI labels and title. I'm currently trying to fix this.

  7. David Platten reporter

    Trying to sort out drilldown for dual plot of DLP and CTDIvol. Having trouble labelling the dual histogram correctly - I can't sort it at the moment. I'm tempted to disable the link from chart labels that takes the user to this dual histogram, but I can't seem to disable that either! I can disable it for the initial drawing of the chart, but once the user has drilled-down and back once then the links from the x-axis are re-enabled. Giving up for the time being. References issue #226.

    → <<cset 506c216ba372>>

  9. David Platten reporter

    Not sure - I'll try and have another look at it when I get home and let you know in the morning, if not before.

  10. David Platten reporter

    Added JavaScript back in to prevent x-axis labels from drilling down to histograms. This is only really necessary for the combined plot of DLP and CTDIvol. Also, this solution is far from perfect as the link is only blocked the first time a user drills down. Once they've drilled back up to the initial plot the x-axis labels will be enabled again. If I can sort out how to display that histogram with correct data labels and tooltips then I'll remove this JavaScript again. This references issue #226

    → <<cset 59a25f6f8a5b>>

  13. David Platten reporter

    Here's a simplified example that shows the problem: http://jsfiddle.net/9phfzewj/21/ The drill down via clicking on a column works fine. The drill down via clicking on an x-axis label results in an incorrectly labelled histogram with two series plotted.

    There's two solutions to this: a. Prevent the x-axis labels from being drill down links b. Sort out the formatting of the dual-histogram plot

    Any help or suggestions greatly appreciated.

  15. Ed McDonagh

    @dplatten is everything not fixed in this issue covered by issue #228? Can this one by resolved so we can include the newer highcharts code and the workaround fixes in the 0.6.0 release?

  18. Log in to comment
Assignee
Type
bug
Priority
major
Status
resolved
Component
Interface: Data visualisation
Milestone
0.6.0
Votes
0
Watchers
2
Jira: the preferred issue tracker for Bitbucket. Join the team!