Flow Thru return location alters water allocation

[Bob Lounsbury]

The attached network demonstrates a different water allocation dependent on whether a flow thru returns it's water upstream or downstream from another demand. My thought is that the overall allocation should be the same, maybe I'm thinking about it incorrectly.

I understand that those return flows can be redistributed, but in this example the flow thru demand should still get the same quantity of water delivered in either scenario due to it's available stored water.

To see the difference simply change the return location for the flow thru from BeforeDiversion to AfterDiversion.

[Bob Lounsbury]

Issue #21 was marked as a duplicate of this issue.

[Bob Lounsbury]

Bug fix - closes #23. Proposed solution is to set bypass links minimum flow to the natural flow allocation. This way the flow thru node is always watching the correct flow in the bypass link and is forced to use storage ownership water to meet its demand.

→ <<cset a8e583dfa61b>>

[Bob Lounsbury]

Only set bypass link to natural flow allocation for demands with storage ownership. ref #23

→ <<cset 8458ac3bd1bb>>

[Enrique T]

See my thoughts on the duplicate issue (#21?). I don't this this is an issue if the bypass credit link is not set. I would question the need for bypass credit link in this setup.

[Bob Lounsbury]

ref #21, #22, #23, #24. Flow thrus with bypass now working and NonStorage flow-thru inflow correct.

→ <<cset d6fe25a84a20>>