4.3.4 Branch Crash on Hunterbot Combat

[Josh Carter]

Hey Trickerer. I know you're still busy, so I don't expect ya to get to this for awhile. I thought I should issue the bug though incase you were not aware of it.

The crash seems to be comming from here:

/

/Barrage: 12% bonus damage for Aimed Shot, Multi-Shot or Volley (removed in SpellHitTarget()) 
            //if (lvl >= 30 && (spellId == AIMED_SHOT || spellId == MULTISHOT ||
            //    spellInfo->IsRankOf(sSpellMgr->GetSpellInfo(VOLLEY_DAMAGE_1))))
            //    pctbonus += 0.12f;

Attached is a debug crashlog.

I'm currently on Trinity Commit 214d0822ce41fb326a9763ae7507923fdfa659f1 (Just for reference) And NPCBot Commit c913db4 (Just for reference)

For now I just commented it out as seem above and there is no more crash. (Not a fix I know. Just letting you know it was narrowed down and tested).

Hope that helps and give ya the proper information to fix it when you have more time.

[trickerer]

VOLLEY_DAMAGE_1 seems to be invalid spellId for 434

[trickerer]

You can just delete this part mentioning VOLLEY_DAMAGE_1 or set it to some blank spell for now. 434 is low priority for me, so I gonna save this one for later

[trickerer]

NPCBots v4.0.16a

Make bots static in world (Closes #77, Closes #72, Closes #89, Closes #90, Closes #68, Closes #96, Closes #101, Closes #104). Drop 4.3.4 branch support (Closes #74, Closes #75, Closes #85, Closes #87) Add basic honor for bots (Closes #30). Bots' stats are no longer depend on players (Closes #83, Ref #97, Ref #98). Convert equips from ItemTemplate from Item and make bots use real items and benefit from all items properties except certain class ability improvements (increase damage, decrease cast time, etc.) (Closes #51). Add Auto-equip option, allows to quick-equip items with simple item comparison algorithm (item level) (Closes #63). Add 'Unequip all' option, allows to unequip all items (Closes #95). Make npcbots' stats fully player-like (Ref #97, Closes #98). Disable custom cooldowns (Closes #97, Closes #100). Modify bots' formation to never spread too much (Closes #99). Allow bots to attack neutral units (Closes #107). Allow npcbots to queue into Dungeon Finder with master (Closes #20). No manual yet

→ <<cset 82d2382ad8bd>>